diff options
author | Benedikt Peetz <benedikt.peetz@b-peetz.de> | 2024-10-14 18:05:33 +0200 |
---|---|---|
committer | Benedikt Peetz <benedikt.peetz@b-peetz.de> | 2024-10-14 18:05:33 +0200 |
commit | 2c7980b773cad586af5db8ff0755f1d74d94f7d1 (patch) | |
tree | 5207aa3a69945ae7d5e5ef77ad14a50313954c25 /crates/libmpv2/src | |
parent | feat(unreachable): Init trait (diff) | |
download | yt-2c7980b773cad586af5db8ff0755f1d74d94f7d1.tar.gz yt-2c7980b773cad586af5db8ff0755f1d74d94f7d1.zip |
refactor(treewide): Conform to the clippy and rust lints
Diffstat (limited to 'crates/libmpv2/src')
-rw-r--r-- | crates/libmpv2/src/mpv.rs | 4 | ||||
-rw-r--r-- | crates/libmpv2/src/mpv/protocol.rs | 2 | ||||
-rw-r--r-- | crates/libmpv2/src/mpv/render.rs | 4 |
3 files changed, 6 insertions, 4 deletions
diff --git a/crates/libmpv2/src/mpv.rs b/crates/libmpv2/src/mpv.rs index 9d554a6..bf4581e 100644 --- a/crates/libmpv2/src/mpv.rs +++ b/crates/libmpv2/src/mpv.rs @@ -51,6 +51,7 @@ fn mpv_err<T>(ret: T, err: ctype::c_int) -> Result<T> { } /// This trait describes which types are allowed to be passed to getter mpv APIs. +#[allow(clippy::missing_safety_doc)] pub unsafe trait GetData: Sized { #[doc(hidden)] fn get_from_c_void<T, F: FnMut(*mut ctype::c_void) -> Result<T>>(mut fun: F) -> Result<Self> { @@ -62,6 +63,7 @@ pub unsafe trait GetData: Sized { } /// This trait describes which types are allowed to be passed to setter mpv APIs. +#[allow(clippy::missing_safety_doc)] pub unsafe trait SetData: Sized { #[doc(hidden)] fn call_as_c_void<T, F: FnMut(*mut ctype::c_void) -> Result<T>>( @@ -207,7 +209,7 @@ pub mod mpv_node { } } - pub fn child(self: Self, node: libmpv2_sys::mpv_node) -> Self { + pub fn child(self, node: libmpv2_sys::mpv_node) -> Self { Self { parent: self.parent, node, diff --git a/crates/libmpv2/src/mpv/protocol.rs b/crates/libmpv2/src/mpv/protocol.rs index 4ae4f16..31a5933 100644 --- a/crates/libmpv2/src/mpv/protocol.rs +++ b/crates/libmpv2/src/mpv/protocol.rs @@ -155,7 +155,7 @@ where { let data = Box::from_raw(cookie as *mut ProtocolData<T, U>); - panic::catch_unwind(|| ((*data).close_fn)(Box::from_raw((*data).cookie))); + panic::catch_unwind(|| (data.close_fn)(Box::from_raw(data.cookie))); } struct ProtocolData<T, U> { diff --git a/crates/libmpv2/src/mpv/render.rs b/crates/libmpv2/src/mpv/render.rs index 91db34e..c3f2dc9 100644 --- a/crates/libmpv2/src/mpv/render.rs +++ b/crates/libmpv2/src/mpv/render.rs @@ -213,8 +213,8 @@ impl RenderContext { params: impl IntoIterator<Item = RenderParam<C>>, ) -> Result<Self> { let params: Vec<_> = params.into_iter().collect(); - let mut raw_params: Vec<libmpv2_sys::mpv_render_param> = Vec::new(); - raw_params.reserve(params.len() + 1); + let mut raw_params: Vec<libmpv2_sys::mpv_render_param> = + Vec::with_capacity(params.len() + 1); let mut raw_ptrs: HashMap<*const c_void, DeleterFn> = HashMap::new(); for p in params { |